Skip to content

Support latest Qt and test on Ubuntu 22.04 #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

ursfassler
Copy link
Contributor

Summary

  • Use Ubuntu 22.04 to build and run tests in addition to Ubuntu 20.04
  • Fix setup to run with Qt version from Ubuntu 22.04

Details

Motivation and Context

It was not possible to use the Qt test driver on a current GNU/Linux distribution. This PR fixes this.

How Has This Been Tested?

The fix is tested by the added Ubuntu 22.04 image that is now also used to build and run the tests.
The problem is show with this run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Feel free to merge.

Also feel free to merge future contributions on your own.

@ursfassler ursfassler merged commit c79100e into cucumber:main Nov 6, 2022
@ursfassler ursfassler deleted the test-also-on-ubuntu-22.04 branch November 6, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants